airbrake-ruby: fix add_filter block API #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
fix-add-filter
branch
from
5696a0c to
79dd070
Compare
Fixes #8 (add_filter throwing exception)
kyrylo
force-pushed
the
fix-add-filter
branch
from
79dd070 to
d5f0939
Compare
| @@ -6,7 +6,7 @@ | |||
| end | |||
|
|
|||
| before do | |||
| described_class.configure do |c| | |||
| @notifier = described_class.configure do |c| | |||
There was a problem hiding this comment.
Would this be more consistent as a let or subject?
There was a problem hiding this comment.
let or subject cache their values, don't they? Here we need to reset the notifier to make sure that we always use a fresh one.
There was a problem hiding this comment.
Cached only within that test https://www.relishapp.com/rspec/rspec-core/v/2-11/docs/helper-methods/let-and-let
There was a problem hiding this comment.
Awesome, thanks. Replaced with let!. PTAL
|
PTAL |
| @@ -5,12 +5,14 @@ | |||
| 'https://airbrake.io/api/v3/projects/113743/notices?key=fd04e13d806a90f96614ad8e529b2822' | |||
| end | |||
|
|
|||
| before do | |||
| let!(:notifier) do | |||
There was a problem hiding this comment.
I don't think you need the !, here, unless I'm missing something?
There was a problem hiding this comment.
Otherwise some tests start failing.
|
LGTM |
kyrylo
added a commit
that referenced
this pull request
Dec 22, 2015
airbrake-ruby: fix add_filter block API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8 (add_filter throwing exception)