filter_chain: don't try to filter nil files #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
117-undefined-sub
branch
from
f71758e to
b91640f
Compare
| @@ -13,7 +13,8 @@ class FilterChain | |||
| notice[:errors].each do |error| | |||
| Gem.path.each do |gem_path| | |||
| error[:backtrace].each do |frame| | |||
| frame[:file].sub!(/\A#{gem_path}/, '[GEM_ROOT]'.freeze) | |||
| next unless (file = frame[:file]) | |||
There was a problem hiding this comment.
Would be nice to have a comment here repeating what you said in PR description "when airbrake-ruby tries to send an exception with a backtrace, which couldn't be parsed. In that case we put the whole frame into function, leaving line and file nil."
|
LGTM |
Fixes #117 (undefined method `sub!' for nil:NilClass) The problem can be reproduced when airbrake-ruby tries to send an exception with a backtrace, which couldn't be parsed. In that case we put the whole frame into `function`, leaving `line` and `file` nil.
kyrylo
force-pushed
the
117-undefined-sub
branch
from
b91640f to
1952717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117 (undefined method `sub!' for nil:NilClass)
The problem can be reproduced when airbrake-ruby tries to send an
exception with a backtrace, which couldn't be parsed. In that case we
put the whole frame into
function, leavinglineandfilenil.