notifier: delete deprecated {whitelist,blacklist}_keys methods #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI alert 🔴 |
kyrylo
force-pushed
the
123-delete-deprecated-methods
branch
from
e9434e1 to
72f59f6
Compare
|
Fixed CI. I have refactored old tests because they were relying on that old API (and removed 2 tests specific to those removed methods). PTAL |
|
This change will require a MINOR version bump, but I would like to postpone it because we've bumped it recently. I would like to get more fixes/features before merging this PR, so the bump is justified. |
|
👍 |
Fixes #123 (Delete deprecated methods)
kyrylo
force-pushed
the
123-delete-deprecated-methods
branch
from
72f59f6 to
db59ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123 (Delete deprecated methods)