notice: deprecate context/action compatibility code #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed to ease transition from v4 to v5, but now we don't want to support this special case due to the ability to `build_notice` and assign `component/action` to the notice directly. It was also impossible to have `component/action` as a normal param key. Deprecating it first, so it can be removed in the next release. I wasn't careful enough, so some of our integrations use this legacy API.
kyrylo
force-pushed
the
deprecate-comp-act-api
branch
from
c5e101f to
0bac37a
Compare
vmihailenco
approved these changes
Jan 19, 2017
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jan 20, 2017
Setting `component/action` like that was deprecated in airbrake/airbrake-ruby#151
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jan 20, 2017
Setting `component/action` like that was deprecated in airbrake/airbrake-ruby#151
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jan 20, 2017
Setting `component/action` like that was deprecated in airbrake/airbrake-ruby#151
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jan 20, 2017
Setting `component/action` like that was deprecated in airbrake/airbrake-ruby#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed to ease transition from v4 to v5, but now we don't
want to support this special case due to the ability to
build_noticeand assign
component/actionto the notice directly. It was alsoimpossible to have
component/actionas a normal param key.Deprecating it first, so it can be removed in the next release. I wasn't
careful enough, so some of our integrations use this legacy API.