airbrake-ruby: deprecate notifier_name argument
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
165-decouple-notifier
branch
from
d4dcc46 to
47fecfc
Compare
shifi
reviewed
Feb 20, 2017
lib/airbrake-ruby.rb
Outdated
| "Use `Airbrake[:#{notifier}]` to access the :#{notifier} notifier " \ | ||
| "and call same methods directly on it." | ||
| ) | ||
| end |
There was a problem hiding this comment.
Move this to method and re-use it?
kyrylo
force-pushed
the
165-decouple-notifier
branch
from
47fecfc to
b4fc115
Compare
Partially resolves #165 (Get rid of third argument in public API methods)
kyrylo
force-pushed
the
165-decouple-notifier
branch
from
b4fc115 to
5a9449c
Compare
|
PTAL |
shifi
approved these changes
Feb 20, 2017
|
would it be simpler to make it part of the options ? |
|
@grosser IMO that would be an overkill because we don't have any other arguments to pass. |
|
I'm fine with either ... don't really care ... only thing that I could use is if |
|
@grosser please file a new issue about this. |
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Feb 24, 2017
The API was introduced in: airbrake/airbrake-ruby#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #165 (Get rid of third argument in public API
methods)