airbrake-ruby,notifier: use the Null Object pattern for notifiers #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
airbrake-713-nil-notifier
branch
2 times, most recently
from
366aced to
d8b2920
Compare
kyrylo
changed the title
Fixes airbrake/airbrake#713 (undefined method `build_notice' for nil:NilClass) It becomes really tedious to keep track of whether a notifier is configured or not. Since we introduced `Airbrake.[]` to retrieve notifiers, all integrations have to add an additional check for it: ```rb if notifier = Airbrake[:default] notifier.notify(...) end ``` With the current change this check is not needed anymore.
kyrylo
changed the title
kyrylo
force-pushed
the
airbrake-713-nil-notifier
branch
from
d8b2920 to
a627629
Compare
vmihailenco
approved these changes
Apr 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes airbrake/airbrake#713
(undefined method `build_notice' for nil:NilClass)
It becomes really tedious to keep track of whether a notifier is
configured or not. Since we introduced
Airbrake.[]to retrievenotifiers, all integrations have to add an additional check for it:
With the current change this check is not needed anymore.