filters/thread_filter: don't serialise IO objects #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
204-segfault-fix
branch
2 times, most recently
from
dffe657 to
73cca98
Compare
Fixes #204 (Airbrake gem segfaults on Circle CI) I stumbled upon an edge case while running the thread filter against a Rails app. The app would stuck because `io_obj.to_json` would never return. The `io_obj` was open. Closed IO objects raise IOError, which we already handle. To make sure we avoid any kind of segfaults, we ignore `:__recursive_key__`, which holds data for PrettyPrint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204 (Airbrake gem segfaults on Circle CI)
I stumbled upon an edge case while running the thread filter against a
Rails app. The app would stuck because
io_obj.to_jsonwould neverreturn. The
io_objwas open. Closed IO objects raise IOError, whichwe already handle.
To make sure we avoid any kind of segfaults, we ignore
:__recursive_key__, which holds data for PrettyPrint.