filters/thread_filter: fixed segfault on Ruby 2.1.3 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Jun 7, 2017
| @@ -57,6 +64,7 @@ def thread_variables(th) | |||
|
|
|||
| def fiber_variables(th) | |||
| th.keys.map.with_object({}) do |key, h| | |||
| next if IGNORED_FIBER_VARIABLES.any? { |v| v == key } | |||
There was a problem hiding this comment.
Can we ignore all vars that start with _? I wanted to suggest this before, but did not want to complicate without a good reason.
kyrylo
force-pushed
the
229-segfault-fix
branch
3 times, most recently
from
8d2182a to
ea083a5
Compare
Fixes #229 (Another segfault report) Ruby segfaults whenever it tries to access `:__recursive_key__`. Unfortunately, there's no other good way to avoid this segfault. `:__recursive_key__` is set by PrettyPrint, so it's very common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229 (Another segfault report)
Ruby segfaults whenever it tries to access
:__recursive_key__.Unfortunately, there's no other good way to avoid this segfault.
:__recursive_key__is set by PrettyPrint, so it's very common.