nested_exception: fix backtrace parsing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
fix-backtrace-parsing
branch
from
dbf45db to
1c5dadf
Compare
|
PTAL |
| @@ -35,7 +35,7 @@ def unwind_exceptions | |||
| end | |||
|
|
|||
| def parse_backtrace(exception) | |||
| return if exception.backtrace.nil? || exception.backtrace.none? | |||
| return [] if exception.backtrace.nil? || exception.backtrace.none? | |||
| Backtrace.parse(exception) | |||
There was a problem hiding this comment.
Please move this check to Backtrace.parse or change this method to:
return [] if exception.backtrace.nil? || exception.backtrace.none?
Backtrace.parse(exception.backtrace)
There was a problem hiding this comment.
Moved the check to Backtrace.parse. Wanted to do the latter, but the Java exceptions check in Backtrace makes it a more complex refactoring (which is not worth it).
|
LGTM |
kyrylo
force-pushed
the
fix-backtrace-parsing
branch
from
1c5dadf to
34cd679
Compare
While working on airbrake/airbrake#479 I stumbled upon a bug in Airbrake Ruby where the default filter couldn't process error payload because `:backtrace` was `nil`. Returning an empty array in case the real backtrace is missing seems to be a more secure approach.
kyrylo
force-pushed
the
fix-backtrace-parsing
branch
from
34cd679 to
934c81c
Compare
kyrylo
added a commit
that referenced
this pull request
Jan 18, 2016
nested_exception: fix backtrace parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on airbrake/airbrake#479 I
stumbled upon a bug in Airbrake Ruby where the default filter couldn't
process error payload because
:backtracewasnil. Returning anempty array in case the real backtrace is missing seems to be a more
secure approach.