airbrake-ruby: reraise SystemExit instead of raising Airbrak::Error #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #28 ("Airbrake::Error: the 'default' notifier isn't configured" thrown after unsuccessful specs) This fixes issues with the Rake integration. There was a [similar issue][1] to a bug with the Rake integration reported a couple of weeks ago. The change presented here fixes both issues by reraising `SystemExit`, which propagates it and gets handled by Ruby. [1]: #13
kyrylo
force-pushed
the
28-special-case-system-exit
branch
from
256ded8 to
a801ba5
Compare
|
LGTM |
kyrylo
added a commit
that referenced
this pull request
Jan 18, 2016
airbrake-ruby: reraise SystemExit instead of raising Airbrak::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28 ("Airbrake::Error: the 'default' notifier isn't configured"
thrown after unsuccessful specs)
This fixes issues with the Rake integration. There was a similar
issue to a bug with the Rake integration reported a couple of weeks
ago. The change presented here fixes both issues by reraising
SystemExit, which propagates it and gets handled by Ruby.