route_sender: fix possible race with increment_stats #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we have routes that report 0 count. In theory, this should never happen because if there's a route record, then the count should be at least 1. I suspect this happens due to a possible race between `send` and `increment_stats`. This gets executed: `@routes[route] ||= RouteStat.new` Then the scheduler switches to `send` and sends the routes. This essentially sends the route with zero data. So far I have no better idea and this is kind of a guess rather than a solid proof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have routes that report 0 count. In theory, this should never
happen because if there's a route record, then the count should be at least 1.
I suspect this happens due to a possible race between
sendandincrement_stats.This gets executed:
@routes[route] ||= RouteStat.newThen the scheduler switches to
sendand sends the routes. This essentiallysends the route with zero data.
So far I have no better idea and this is kind of a guess rather than a solid
proof.