Delete NilNotifiers and rely on notifier config checks #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a notifier is not configured, we can `add_filter` but `notify` won't have effect. This accompanies #445.
kyrylo
force-pushed
the
nil-notifier-removal
branch
from
fe56299 to
307185e
Compare
|
I believe this PR brought back #80 |
|
C'mon, guys, this is ridiculous, I'm trying to revert to an older version, and the only alternatives I have are
|
|
I know a workaround for this, but I don't understand why I have to spend time searching for workarounds for something that we pay money for |
|
Can you please open a new issue and share your config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a notifier is not configured, we can
add_filterbutnotifywon't haveeffect. This accompanies #445.