airbrake-ruby: don't raise error when there's no project id/key #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes airbrake/airbrake#931. (`Airbrake::Error: :project_id is required` is thrown for ignored environment) This is technically not a bug since we even test that we raise an error, but an oversight.
kyrylo
force-pushed
the
931-required-options-fix
branch
from
f701614 to
d859dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes airbrake/airbrake#931.
(
Airbrake::Error: :project_id is requiredis thrown for ignored environment)This is technically not a bug since we even test that we raise an error, but an
oversight.