airbrake-ruby: don't overwrite notifiers on #configure #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
changed the title
The `reset` method introduced in v4.2.2 was resetting Airbrake every time we call `configure`. This can result in default filters being lost. E.g. we `add_filter` and then `configure`. There are two solutions: * we add filters within `configure` * we don't call reset when notifiers are already registered I chose the latter because it's a simpler approach and it does the job. I will keep in mind the first approach since it sounds more logical to me. Currently, we decouple "configuration" and filters, however they are the same thing and adding filters *is* configuration. That said, this approach has caveats. For example, I wan't to add some filters in some integration. I don't want to reconfigure the whole thing, I just want to append my tiny little filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resetmethod introduced in v4.2.2 was resetting Airbrake every time wecall
configure. This can result in default filters being lost. E.g. weadd_filterand thenconfigure.There are two solutions:
configureI chose the latter because it's a simpler approach and it does the job. I will
keep in mind the first approach since it sounds more logical to me. Currently,
we decouple "configuration" and filters, however they are the same thing and
adding filters is configuration. That said, this approach has caveats. For
example, I wan't to add some filters in some integration. I don't want to
reconfigure the whole thing, I just want to append my tiny little filter.