Implement the "query_stats" option and disable it #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely fixes: * airbrake/airbrake#994 (Memory usage) * airbrake/airbrake#990 (CPU and Average Response increased after version 7) The SQL query collection feature is still in alpha and we display it only for certain accounts. Therefore, the vast majority of our customers cannot even see what airbrake-ruby collects. Since the feature is still in alpha, it is currently buggy (in a sense that it consumes too much memory & CPU power). I profiled a Rails app on a certain route with `memory_profiler` for Rack Mini Profiler and I can see a significant increase of memory usage. === performance_stats = false ``` Total allocated: 12434583 bytes (145711 objects) Total retained: 508023 bytes (3346 objects) allocated memory by gem 264 airbrake/lib ``` === performance_stats = true && query_stats = false ``` Total allocated: 12461685 bytes (146002 objects) Total retained: 508431 bytes (3353 objects) allocated memory by gem 3816 airbrake/lib ``` === performance_stats = true && query_stats = true ``` Total allocated: 186535107 bytes (1447037 objects) Total retained: 35810972 bytes (349882 objects) allocated memory by gem 709720 airbrake/lib ``` According to these reports memory usage ramped up by 700% compared to the route stats feature. The route stats feature itself is already quite expensive and the query collection feature is just too much.
kyrylo
force-pushed
the
query-stats-option
branch
from
9a71155 to
dd106cd
Compare
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Aug 5, 2019
Likely fixes: * #994 (Memory usage) * #990 (Add support for Rails engine route prefixes) More details in airbrake/airbrake-ruby#495. In short, this disables SQL query collection by default and allows enabling it only for certain accounts.
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Aug 5, 2019
Likely fixes: * #994 (Memory usage) * #990 (Add support for Rails engine route prefixes) More details in airbrake/airbrake-ruby#495. In short, this disables SQL query collection by default and allows enabling it only for certain accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely fixes:
increased after version 7)
The SQL query collection feature is still in alpha and we display it only for
certain accounts. Therefore, the vast majority of our customers cannot even see
what airbrake-ruby collects. Since the feature is still in alpha, it is
currently buggy (in a sense that it consumes too much memory & CPU power).
I profiled a Rails app on a certain route with
memory_profilerfor Rack MiniProfiler and I can see a significant increase of memory usage.
=== performance_stats = false
=== performance_stats = true && query_stats = false
=== performance_stats = true && query_stats = true
According to these reports memory usage ramped up by 700% compared to the route
stats feature. The route stats feature itself is already quite expensive and the
query collection feature is just too much.