performance_notifier: add #notify_sync #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
notify-queue-sync
branch
2 times, most recently
from
eb50ae3 to
4274859
Compare
`PerformanceNotifier#notify_sync` exists for the same reasons as `NoticeNotifier#notify_sync`. In certain scenarios, such as Resque jobs, `AsyncSender` dies before it can send something. Because `PerformanceNotifier` waits 15 seconds before sending payload, it's guaranteed that once a Resque job finishes, it also kills `PerformanceNotifier` before it can send. This is the unfortunate effect of forking. To cope with this, we must send synchronously.
kyrylo
force-pushed
the
notify-queue-sync
branch
from
4274859 to
b3c3ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerformanceNotifier#notify_syncexists for the same reasons asNoticeNotifier#notify_sync.In certain scenarios, such as Resque jobs,
AsyncSenderdies before it can sendsomething. Because
PerformanceNotifierwaits 15 seconds before sendingpayload, it's guaranteed that once a Resque job finishes, it also kills
PerformanceNotifierbefore it can send. This is the unfortunate effect offorking.
To cope with this, we must send synchronously.