filters: filter context payload #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
context-filtering
branch
from
f665d35 to
75a4f3b
Compare
|
This is a bit tricky. We perform URL params filtering, so with the present change it breaks (we simply replace the whole URL instead of specific params). I think stuff in the context payload should still not be filterable, that said it makes sense to filter out |
kyrylo
force-pushed
the
context-filtering
branch
2 times, most recently
from
7ee08db to
fb8f3f3
Compare
|
PTAL |
A user reported that it's not possible to filter context/user. It's a reasonable request given that the user information has been moved to context recently. Here we special-case context/user because we do want to be able to filter it, but we don't want to filter out other payload in `context`.
kyrylo
force-pushed
the
context-filtering
branch
from
fb8f3f3 to
e336ac5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that it's not possible to filter context/user. It's a
reasonable request given that the user information has been moved to
context recently.