Refactor Airbrake.blacklist/whitelist_keys to be an option #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
53-refactor-filtering-api
branch
4 times, most recently
from
3d35508 to
e2a9e5f
Compare
| etc) should be filtered. Before sending an error, filtered keys will be | ||
| substituted with the `[Filtered]` label. | ||
|
|
||
| It accepts Strings, Symbols & Regexps, which represent keys to be filtered. |
There was a problem hiding this comment.
Nitpick: values are filtered here, so maybe change this to be more consistent with L291
There was a problem hiding this comment.
Changed to It accepts Strings, Symbols & Regexps, which represent keys of values to be filtered., thanks!
|
Few minor comments, otherwise LGTM |
Fixes #53 (Expose blacklist_keys and whitelist_keys as config options)
kyrylo
force-pushed
the
53-refactor-filtering-api
branch
from
e2a9e5f to
af8a99a
Compare
kyrylo
added a commit
that referenced
this pull request
Mar 4, 2016
Refactor Airbrake.blacklist/whitelist_keys to be an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53 (Expose blacklist_keys and whitelist_keys as config options)