filters/git_last_checkout: add support for AIRBRAKE_DEPLOY_USERNAME #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
airbrake-deploy-username
branch
2 times, most recently
from
86e31d2 to
603f9b0
Compare
In certain environments, when a deploy starts, end deploy user might not be the one who started the deploy. For example, if you deploy via Ansible, the script could create a fake user who would pull the web app repo and deploy it for you. Even though you started the script, the filter will pick up the fake user name, since `.git` was created by that user. To work around that, we introduce the `AIRBRAKE_DEPLOY_USERNAME` env variable. With help of it we can forward the username from Ansible to Ruby.
kyrylo
force-pushed
the
airbrake-deploy-username
branch
from
603f9b0 to
631eda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments, when a deploy starts, end deploy user might not be the
one who started the deploy. For example, if you deploy via Ansible, the script
could create a fake user who would pull the web app repo and deploy it for
you. Even though you started the script, the filter will pick up the fake user
name, since
.gitwas created by that user.To work around that, we introduce the
AIRBRAKE_DEPLOY_USERNAMEenvvariable. With help of it we can forward the username from Ansible to Ruby.