remote_settings: delete the code for config dumping/loading #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our users complain that our airbrake-ruby notifier tries to dump the remote config that we pull from S3 to the gem directory. The OS user that is running the code may not have write access to that directory and therefore writing the remote config will fail. There's no good universal location to keep persistent remote config, so it's easier just to delete the config.
kyrylo
force-pushed
the
notifier-config-dump-removal
branch
from
9c88e3f to
89621cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our users complain that our airbrake-ruby notifier tries to dump the
remote config that we pull from S3 to the gem directory. The OS user that is
running the code may not have write access to that directory and therefore
writing the remote config will fail.
There's no good universal location to keep persistent remote config, so it's
easier just to delete the config.