Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/processor: disable notifier config polling for test envs #622

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

kyrylo
Copy link
Contributor

@kyrylo kyrylo commented Oct 20, 2020

People who depend on this library shouldn't be concerned with stubbing notifier
config HTTP GET calls in their test suites. By tying this with 'environment' we
win a lot: no need to document anything and no need to do anything for those who
depend on airbrake-ruby.

People who depend on this library shouldn't be concerned with stubbing notifier
config HTTP GET calls in their test suites. By tying this with 'environment' we
win a lot: no need to document anything and no need to do anything for those who
depend on airbrake-ruby.
@kyrylo kyrylo force-pushed the remote-config-test-env-off branch from 4f7c9c2 to adeb780 Compare October 20, 2020 07:37
@kyrylo kyrylo merged commit d5aee03 into master Oct 20, 2020
@kyrylo kyrylo deleted the remote-config-test-env-off branch October 20, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant