Drop support for Ruby 2.3 & 2.4 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
ruby-version-lock
branch
from
7bb0018 to
1e28ff1
Compare
We no longer test on these rubies and this caused some [trouble][1] with the
Airbrake gem. We didn't catch this error becasue the Airbrake gem still tests on
2.3 & 2.4, but airbrake-ruby doesn't. We also never dropped support 2.3 & 2.4,
which left the whole situation in limbo.
```
5) Airbrake::Rack::Instrumentable.********_capture_timing when request store has a route attaches timing for a method with all arg types
Failure/Error: params[:groups].merge!(timed_trace.spans)
NoMethodError:
undefined method `transform_values' for #<Hash:0x000055b7ee9f7300>
```
Since 2.3 & 2.4 are EOL for a long time (March 31, 2020 for 2.4), we can safely
stop supporting these rubies.
[1]: https://app.circleci.com/pipelines/github/airbrake/airbrake/215/workflows/d3f04866-05b9-4da6-ba15-b0c285eb0c23/jobs/9590
kyrylo
force-pushed
the
ruby-version-lock
branch
from
1e28ff1 to
aacc145
Compare
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Sep 20, 2021
Airbrake Ruby no longer supports these versions as of airbrake/airbrake-ruby#663.
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Sep 20, 2021
Airbrake Ruby no longer supports these versions as of airbrake/airbrake-ruby#663.
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Sep 21, 2021
Airbrake Ruby no longer supports these versions as of airbrake/airbrake-ruby#663.
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Sep 21, 2021
Airbrake Ruby no longer supports these versions as of airbrake/airbrake-ruby#663.
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Sep 21, 2021
Airbrake Ruby no longer supports these versions as of airbrake/airbrake-ruby#663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer test on these rubies and this caused some trouble with the
Airbrake gem. We didn't catch this error becasue the Airbrake gem still tests on
2.3 & 2.4, but airbrake-ruby doesn't. We also never dropped support 2.3 & 2.4,
which left the whole situation in limbo.
Since 2.3 & 2.4 are EOL for a long time (March 31, 2020 for 2.4), we can safely
stop supporting these rubies.