thread_pool: change severity of "full queue" msg from error to info #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
thread-pool-log-fix
branch
from
08fa442 to
beb8f33
Compare
Some of our users complained that `message.inspect` "pressures" their server memory. Indeed, the dumped string can be large (up to 64KB). Instead, let's change the severity of this message to `info`, so that it won't be printed by default. It's not really an error anyway, and the `info` severity suits it perfectly. `message.inspect` also won't be called by default anymore, since it's wrapped in a block now.
I don't like how it looks like.
kyrylo
force-pushed
the
thread-pool-log-fix
branch
from
12fca79 to
d873edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our users complained that
message.inspect"pressures" their servermemory. Indeed, the dumped string can be large (up to 64KB).
Instead, let's change the severity of this message to
info, so that it won'tbe printed by default. It's not really an error anyway, and the
infoseveritysuits it perfectly.
message.inspectalso won't be called by default anymore, since it's wrapped ina block now.