Correctly handle a frozen string with invalid characters #73
Conversation
| @@ -109,11 +109,12 @@ def truncate_string(str) | |||
| # @return [void] | |||
| # @note This method mutates +str+ for speed | |||
There was a problem hiding this comment.
Could you delete this line and update the line above?
There was a problem hiding this comment.
Sure. Also, would you prefer keeping the bang in the method name since it still modifies the argument when it's not frozen?
There was a problem hiding this comment.
Good call, it makes sense. I guess it's also better to update this note, to mention that it mutates every but frozen strings.
bobes
force-pushed
the
fix_frozen_string_bug
branch
from
cf6c3aa to
39c1234
Compare
| # @note This method mutates +str+ for speed | ||
| # @return [String] a UTF-8 encoded string | ||
| # @note This method mutates +str+ unless it's frozen, | ||
| # in which case it creates a duplicate |
There was a problem hiding this comment.
According to YARD (the notation we use to generate docs), we should be using two spaces here:
# @note This method mutates +str+ unless it's frozen,
# in which case it creates a duplicate
|
Massive thanks for the PR, @bobes, great find & PR! |
bobes
force-pushed
the
fix_frozen_string_bug
branch
from
39c1234 to
9184b7d
Compare
|
thanks for the feedback, I hope it's alright now :) I would appreciate if you could bump the version and push it to rubygems, thank you. |
|
Sure, expect a release today. :) |
|
Just released |
This change fixes a
RuntimeError: can't modify frozen Stringerror that happens in Payload Truncator when a string with invalid characters is frozen