Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump cdk to 6.6.4 #540

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Nov 19, 2024

Summary by CodeRabbit

  • Chores
    • Updated the version constraint for the airbyte-cdk dependency to enhance compatibility and stability.

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Nov 19, 2024

/poetry-lock

poetry lock job started... Check job output.

poetry lock applied successfully.

Resolving dependencies... changes
Copy link

coderabbitai bot commented Nov 19, 2024

📝 Walkthrough

Walkthrough

The pull request updates the pyproject.toml file, specifically modifying the version constraint for the airbyte-cdk dependency from ^6.6.3,!=6.7.0rc1 to ^6.6.4,!=6.7.0rc1,!=6.7.0rc2. This change allows for a newer version while excluding two specific release candidates. All other dependencies remain unchanged, and the file's overall structure and comments are preserved.

Changes

File Change Summary
pyproject.toml Updated airbyte-cdk dependency version from ^6.6.3,!=6.7.0rc1 to ^6.6.4,!=6.7.0rc1,!=6.7.0rc2

Possibly related PRs

Wydt about exploring these related PRs for additional context or insights?


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5164d1f and 86a3f76.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

18-18: LGTM on the CDK version bump! Mind if we verify the changes? 🔍

The change from ^6.6.3,!=6.7.0rc1 to ^6.6.4,!=6.7.0rc1,!=6.7.0rc2 looks good. I notice we're excluding an additional release candidate (rc2) - would you mind sharing the context on why we need to exclude it? This could help future maintainers understand the decision, wdyt? 🤔

Let's check the changelog between these versions:

✅ Verification successful

The CDK version bump looks safe to proceed! 🚀

I've verified that:

  • The versions 6.6.4 and 6.7.0rc2 are available on PyPI
  • No security advisories were found for these versions
  • The dependency is properly locked in poetry.lock
  • The versioning follows semantic versioning as per docs/CONTRIBUTING.md

Would you mind adding a quick note in the PR description about why we're excluding 6.7.0rc2? This would help future maintainers understand the context better, wdyt? 🤔

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the changelog between 6.6.3 and 6.6.4, and look for any known issues with rc2

# Fetch the package info from PyPI
echo "Checking airbyte-cdk versions..."
curl -s https://pypi.org/pypi/airbyte-cdk/json | jq -r '.releases | keys[]' | grep -E "6\.6\.[3-4]|6\.7\.0rc2"

# Check for any security advisories
echo "Checking for security advisories..."
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: PIP, package: "airbyte-cdk") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Length of output: 634


Script:

#!/bin/bash
# Let's check the repository for any changelog entries or documentation about version compatibility

# Look for changelog files
echo "Looking for changelog files..."
fd -i changelog

# Search for any mentions of CDK version 6.6.4 or 6.7.0rc2 in the codebase
echo "Searching for version mentions..."
rg -i "6\.6\.4|6\.7\.0rc2"

# Look for any documentation about version requirements
echo "Checking documentation..."
fd -e md -e rst | xargs rg -i "airbyte.?cdk|version|compatibility" -C 2

Length of output: 2817


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaronsteers aaronsteers marked this pull request as ready for review November 19, 2024 06:47
@aaronsteers aaronsteers changed the title bump cdk chore: bump cdk to 6.6.4 Nov 19, 2024
@aaronsteers aaronsteers changed the title chore: bump cdk to 6.6.4 Chore: Bump cdk to 6.6.4 Nov 19, 2024
@aaronsteers aaronsteers enabled auto-merge (squash) November 19, 2024 06:51
@aaronsteers aaronsteers merged commit f2529a6 into main Nov 19, 2024
19 of 21 checks passed
@aaronsteers aaronsteers deleted the aj/chore/bump-airbyte-cdk-to-6-6-4 branch November 19, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant