-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump jsonschema
to "~4.17.3"
#68
Conversation
jsonschema
to "~4.17.3"
📝 WalkthroughWalkthroughThe pull request primarily updates the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant DependencyManager
User->>System: Request to update dependencies
System->>DependencyManager: Check for updates
DependencyManager-->>System: Found updates for jsonschema and pydantic
System->>DependencyManager: Apply updates
DependencyManager-->>System: Updates applied successfully
System-->>User: Dependencies updated
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (3)pyproject.toml (3)
The comment about avoiding 4.18 due to breaking changes is super helpful for future maintainers! 👍
Hey! I notice we're upgrading jsonschema from ~3.2.0 to ~4.17.3. While the comment about avoiding 4.18 is helpful, have we verified compatibility with the 3.x to 4.x upgrade? This is a major version bump that might introduce breaking changes. Let's check for any direct jsonschema usage in the codebase: Would it be worth adding a test specifically for jsonschema validation to ensure the upgrade doesn't affect existing functionality? I'd be happy to help craft one if you'd like!
I see we're using Pydantic v2 (
Let's check our Pydantic usage: Would it be helpful to add a section in the README about Pydantic v2 compatibility? wdyt? 🤔 Also applies to: 48-48 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thanks @aaronsteers 🫡 This should allow me to install pyairbyte into my dagster/dbt project now! |
Summary by CodeRabbit
New Features
jsonschema
dependency to a more recent version, enhancing compatibility with newer features.Bug Fixes