Skip to content

Commit

Permalink
🐛Destination-dynamodb: fixed build's run (#13303)
Browse files Browse the repository at this point in the history
* [13180] Destination-dynamodb: fixed build's run
  • Loading branch information
etsybaev authored May 30, 2022
1 parent ab81e4d commit ae95d29
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
- name: DynamoDB
destinationDefinitionId: 8ccd8909-4e99-4141-b48d-4984b70b2d89
dockerRepository: airbyte/destination-dynamodb
dockerImageTag: 0.1.2
dockerImageTag: 0.1.3
documentationUrl: https://docs.airbyte.io/integrations/destinations/dynamodb
icon: dynamodb.svg
releaseStage: alpha
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1111,15 +1111,15 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-dynamodb:0.1.2"
- dockerImage: "airbyte/destination-dynamodb:0.1.3"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/dynamodb"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "DynamoDB Destination Spec"
type: "object"
required:
- "dynamodb_table_name"
- "dynamodb_table_name_prefix"
- "dynamodb_region"
- "access_key_id"
- "secret_access_key"
Expand All @@ -1133,10 +1133,10 @@
\ AWS DynamoDB, just leave empty)."
examples:
- "http://localhost:9000"
dynamodb_table_name:
title: "DynamoDB Table Name"
dynamodb_table_name_prefix:
title: "Table name prefix"
type: "string"
description: "The name of the DynamoDB table."
description: "The prefix to use when naming DynamoDB tables."
examples:
- "airbyte_sync"
dynamodb_region:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-dynamodb

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.version=0.1.3
LABEL io.airbyte.name=airbyte/destination-dynamodb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@
import com.amazonaws.services.dynamodbv2.document.*;
import com.amazonaws.services.dynamodbv2.document.spec.ScanSpec;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
import io.airbyte.commons.io.IOs;
import io.airbyte.commons.jackson.MoreMappers;
import io.airbyte.commons.json.Jsons;
import io.airbyte.integrations.base.JavaBaseConstants;
import io.airbyte.integrations.standardtest.destination.DestinationAcceptanceTest;
Expand All @@ -30,7 +28,6 @@
public class DynamodbDestinationAcceptanceTest extends DestinationAcceptanceTest {

private static final Logger LOGGER = LoggerFactory.getLogger(DynamodbDestinationAcceptanceTest.class);
protected static final ObjectMapper MAPPER = MoreMappers.initMapper();

protected final String secretFilePath = "secrets/config.json";
protected JsonNode configJson;
Expand Down Expand Up @@ -69,7 +66,6 @@ protected List<Item> getAllSyncedObjects(final String streamName, final String n
final var tableName = DynamodbOutputTableHelper.getOutputTableName(this.config.getTableNamePrefix(), streamName, namespace);
final var table = dynamodb.getTable(tableName);
final List<Item> items = new ArrayList<Item>();
final List<Item> resultItems = new ArrayList<Item>();
Long maxSyncTime = 0L;

try {
Expand All @@ -86,7 +82,6 @@ protected List<Item> getAllSyncedObjects(final String streamName, final String n
LOGGER.error(e.getMessage());
}

final Long finalMaxSyncTime = maxSyncTime;
items.sort(Comparator.comparingLong(o -> ((BigDecimal) o.get(JavaBaseConstants.COLUMN_NAME_EMITTED_AT)).longValue()));

return items;
Expand Down

0 comments on commit ae95d29

Please sign in to comment.