Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class support for date types in Airbyte #1006

Closed
sherifnada opened this issue Nov 17, 2020 · 4 comments
Closed

First class support for date types in Airbyte #1006

sherifnada opened this issue Nov 17, 2020 · 4 comments
Assignees
Labels
area/connectors Connector related issues priority/high High priority type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Nov 17, 2020

Tell us about the problem you're trying to solve

We currently map string-formatted dates e.g: ISO8601 as strings even when normalization is enabled in the destination. This makes it harder to leverage the data correctly in the destination when normalized. This issue aims to address that. The basic criteria for closing this issue is:

  • In the types contained within AirbyteCatalog, support JsonSchema date/time types.
  • In basic normalization, string-formatted date types are written into a column with the appropriate date/time type.
  • Follow up issues have been created to make sources express the date/time formatting of string-represented date fields correctly.

This issue is more of an "epic" -- it will almost certainly require creating multiple child issues for each component of the solution.

┆Issue is synchronized with this Asana task by Unito

@sherifnada sherifnada added the type/enhancement New feature or request label Nov 17, 2020
@cgardens
Copy link
Contributor

cgardens commented Dec 14, 2020

@sherifnada we add the user stories on this. is the only thing we are trying to achieve here that when we run normalization it is surfaced with the correct type? I'm asking it in this way, because I suspect there's actually more that we want from this.

@jrhizor
Copy link
Contributor

jrhizor commented Jan 21, 2021

We currently do have several catalogs that are labelling date-time appropriately. Some don't, like Github: #1751

This should be a pretty high priority issue since it directly and negatively impacts the ability to play with data produced by normalization. Without a DBT-like step, all time-based analytics becomes impossible without writing some sort of a SQL "view" of the data. If someone is using Metabase/Looker/etc, they won't be able to create any time based graphs without this functionality.

An example of something that would require custom grouping queries do to the lack of this feature:
airbytehq/write-for-the-community#29

@jrhizor jrhizor added the priority/high High priority label Jan 21, 2021
@ChristopheDuong
Copy link
Contributor

If someone is using Metabase/Looker/etc, they won't be able to create any time based graphs without this functionality.

In metabase and looker, you can create "parameters" or "dimensions" (SQL Columns) specifying an SQL queries instead of just their name so you can actually say cast(my_data_column_in_string as timestamp) and it will convert it to a proper timestamp for use in the charts

That's probably why we initially decided that support for date time types on the first iteration wasn't such a blocker for BI/analysis usage down the line...

But yes, it would be nice if more catalogs exposed the proper type and we correctly cast to it in normalization

@jrhizor jrhizor modified the milestone: 2021-03-05 Mar 1, 2021
@ChristopheDuong
Copy link
Contributor

It seems like we don't handle integer type natively either and always end up casting them to float in the destination as they transit with number type in json primitive type:

case INTEGER -> JsonSchemaPrimitive.NUMBER;

@davinchia davinchia added this to the Airbyte Beta Release milestone May 10, 2021
@sherifnada sherifnada added the area/connectors Connector related issues label Jun 2, 2021
@sherifnada sherifnada modified the milestones: Airbyte Beta Release, Core 2021-08-04 Jul 28, 2021
davydov-d added a commit that referenced this issue Nov 11, 2022
davydov-d added a commit that referenced this issue Nov 11, 2022
…9349)

* #1006 source freshdesk: do not call response.json() inside should_retry

* #1006 source freshdesk: upd changelog

* run code format

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
akashkulk pushed a commit that referenced this issue Dec 2, 2022
…9349)

* #1006 source freshdesk: do not call response.json() inside should_retry

* #1006 source freshdesk: upd changelog

* run code format

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues priority/high High priority type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants