stream/field name validation/filtering #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
approved these changes
Nov 17, 2020
sherifnada
approved these changes
Nov 17, 2020
|
|
||
| if (!invalidStreamNames.isEmpty()) { | ||
| invalidStreamNames.forEach(streamName -> LOGGER.error("Cannot sync invalid stream name: " + streamName)); | ||
| return new OutputAndStatus<>(JobStatus.FAILED); |
There was a problem hiding this comment.
can we also return a message describing why discovery failed so we can show this on the UI?
There was a problem hiding this comment.
OutputAndStatus doesn't allow for error messages unfortunately. Adding messages outside of logs seems a bit out of scope for this PR. Added #1011
There was a problem hiding this comment.
I understand that, but I'm just worried that in its current state, there is no way for the user to know what's wrong. It'll just look like airbyte is broken if e.g: they sync Gsheets with a space in the name, and all they'll see on the UI is "an error happened"
michel-tricot
approved these changes
Nov 18, 2020
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
We should have a test with Unicode
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #954
Resolves #972
Start at
CatalogHelpers.java.Might need to address any discovery failures for existing API sources if they fail on integration tests here.