Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Shopify: Minor specification re-order, fixed links in documentation #10794

Merged
merged 15 commits into from
Mar 4, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 2, 2022

What

Due to MLP tasks for source Shopify we need to update the documentation and reorder the specification structure.

How

  • edited the order of the Specification, to map this structure: Authorization Method, Shopify Store, Start Date
  • reviewed and edited all links to official Shopify documentation for streams

🚨 User Impact 🚨

No user impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Mar 2, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Mar 2, 2022
@bazarnov bazarnov linked an issue Mar 2, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 2, 2022
@bazarnov bazarnov temporarily deployed to more-secrets March 2, 2022 14:03 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 2, 2022 14:03 Inactive
@bazarnov bazarnov mentioned this pull request Mar 2, 2022
12 tasks
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 2, 2022

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1922672232
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1922672232
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_shopify/__init__.py        2      0   100%
source_shopify/transform.py      58      3    95%
source_shopify/utils.py          58      6    90%
source_shopify/auth.py           20      4    80%
source_shopify/source.py        272    103    62%
-------------------------------------------------
TOTAL                           410    116    72%

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 2, 2022 14:14 Inactive
@codecov

This comment was marked as outdated.

@bazarnov bazarnov requested a review from lazebnyi March 2, 2022 14:43
@bazarnov bazarnov temporarily deployed to more-secrets March 3, 2022 12:44 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 3, 2022 12:44 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 3, 2022 12:46 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 3, 2022 13:04 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 3, 2022 13:05 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 3, 2022 13:06 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 3, 2022

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1928266459
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1928266459
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_shopify/__init__.py        2      0   100%
source_shopify/transform.py      58      3    95%
source_shopify/utils.py          58      6    90%
source_shopify/auth.py           20      4    80%
source_shopify/source.py        272    103    62%
-------------------------------------------------
TOTAL                           410    116    72%

@bazarnov bazarnov changed the title 🐛 Source Shopify: fixed abandoned_checkouts schema issue during normalisation. 🐛 Source Shopify: Minor specification re-order, fixed links in documentation Mar 4, 2022
@bazarnov bazarnov requested a review from sherifnada March 4, 2022 12:20
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:23 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:23 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:26 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:26 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 4, 2022 12:27 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 4, 2022

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1933776937
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1933776937
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_shopify/__init__.py        2      0   100%
source_shopify/transform.py      58      3    95%
source_shopify/utils.py          58      6    90%
source_shopify/auth.py           20      4    80%
source_shopify/source.py        272    103    62%
-------------------------------------------------
TOTAL                           410    116    72%

@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:52 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 12:52 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 4, 2022 12:52 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 4, 2022

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1934614895
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1934614895

@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 15:55 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 15:55 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 4, 2022 15:56 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 17:25 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 4, 2022 17:25 Inactive
@bazarnov bazarnov merged commit 21a8844 into master Mar 4, 2022
@bazarnov bazarnov deleted the bazarnov/shopify-fix-ab-checkouts-schema branch March 4, 2022 17:26
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation type/bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants