-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mina-sshd from 2.7.0 to 2.8.0 #11514
Conversation
Thank you for spotting this @evansmurithi , I'm going to try to run our test suite on your branch to check if the test passes. |
@alafanechere could you raise the discussion with connector team because this could impact all destinations using Java with SSH tunnels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgive my taking back here. I was late to the conversation. sorry for the mixed signal :(
@evansmurithi I just wanted to explain myself here Evan, sorry for the drama. I thought this was an internal team request which I'm more trigger happy to grant. We will need to release a new version of every connector for this change, which is probably fine, but I want approval from that team before moving forward. You will hear back from us soon, I just jumped the gun. Sorry for the noise, thank you for the PR. Your contribution is welcome and appreciated. |
@supertopher no worries. That makes sense 🙂 |
I confirm I was able to build and I also successfully ran the connector base build from this in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please make sure to publish all dependent connector versions
/test connector=connectors/destination-bigquery
|
Marcos Marx commented: @alafanechere could you raise the discussion with connector team because this could impact all destinations using Java with SSH tunnels. |
/test connector=connectors/destination-azure-blob-storage
|
/test connector=connectors/destination-bigquery-denormalized
|
/test connector=connectors/destination-bigquery
|
/test connector=connectors/destination-keen
|
/test connector=connectors/destination-clickhouse
|
/test connector=connectors/destination-dynamodb
|
/test connector=connectors/destination-e2e-test
|
/test connector=connectors/destination-elasticsearch
|
/test connector=connectors/destination-gcs
|
/test connector=connectors/destination-pubsub
|
/test connector=connectors/destination-kafka
|
/test connector=connectors/destination-kinesis
|
/publish connector=connectors/destination-clickhouse
|
/test connector=connectors/destination-postgres
|
Auto-bump is currently broken (#12276). Once that is fixed, this PR will be much easier to complete. |
this is an attempt to merge the main change from #11514, which now has multiple conflicts. The gist of the change When creating a Postgres destination connector with SSH tunnel method 'SSH Key Authentication', one is required to provide a RSA key. Creating a rsa-sha2-256 or rsa-sha2-512 key, will result in the error SshException: KeyExchange signature verification failed for key type=ssh-rsa, if you haven't enabled ssh-rsa in the SSH server's host key algorithms. mina-sshd in version 2.7.0 uses the wrong server key signature algorithm during DH group key exchange. https://issues.apache.org/jira/browse/SSHD-1163. Bumping mina-sshd to version 2.8.0 addresses this issue. Changelog https://github.com/apache/mina-sshd/blob/master/docs/changes/2.8.0.md.
@evansmurithi thank you for the change. The updated docker images have been published and versions updated in OSS platform. I am merging the main change here: #12376. Once the main change is merged, I'll close this PR. |
this is an attempt to merge the main change from #11514, which now has multiple conflicts. The gist of the change When creating a Postgres destination connector with SSH tunnel method 'SSH Key Authentication', one is required to provide a RSA key. Creating a rsa-sha2-256 or rsa-sha2-512 key, will result in the error SshException: KeyExchange signature verification failed for key type=ssh-rsa, if you haven't enabled ssh-rsa in the SSH server's host key algorithms. mina-sshd in version 2.7.0 uses the wrong server key signature algorithm during DH group key exchange. https://issues.apache.org/jira/browse/SSHD-1163. Bumping mina-sshd to version 2.8.0 addresses this issue. Changelog https://github.com/apache/mina-sshd/blob/master/docs/changes/2.8.0.md.
this is an attempt to merge the main change from #11514, which now has multiple conflicts. The gist of the change When creating a Postgres destination connector with SSH tunnel method 'SSH Key Authentication', one is required to provide a RSA key. Creating a rsa-sha2-256 or rsa-sha2-512 key, will result in the error SshException: KeyExchange signature verification failed for key type=ssh-rsa, if you haven't enabled ssh-rsa in the SSH server's host key algorithms. mina-sshd in version 2.7.0 uses the wrong server key signature algorithm during DH group key exchange. https://issues.apache.org/jira/browse/SSHD-1163. Bumping mina-sshd to version 2.8.0 addresses this issue. Changelog https://github.com/apache/mina-sshd/blob/master/docs/changes/2.8.0.md.
Testing!!!## What
When creating a Postgres destination connector with SSH tunnel method 'SSH Key Authentication', one is required to provide a RSA key. Creating a
rsa-sha2-256 or rsa-sha2-512
key, will result in the errorSshException: KeyExchange signature verification failed for key type=ssh-rsa
, if you haven't enabled ssh-rsa in the SSH server's host key algorithms.mina-sshd in version 2.7.0 uses the wrong server key signature algorithm during DH group key exchange. https://issues.apache.org/jira/browse/SSHD-1163.
How
Bumping mina-sshd to version 2.8.0 addresses this issue. Changelog https://github.com/apache/mina-sshd/blob/master/docs/changes/2.8.0.md.
Recommended reading order
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.