Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Freshdesk: Migrated to latest CDK #12334

Merged
merged 22 commits into from
May 30, 2022
+1,247 −722
Merged

🎉 Source Freshdesk: Migrated to latest CDK #12334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8ef1f22
Started migration
lgomezm Apr 17, 2022
3733c3c
Migrated more streams
lgomezm Apr 17, 2022
74b9a16
Refactored usage of authenticator
lgomezm Apr 17, 2022
002127b
Migrated tickets and conversations
lgomezm Apr 17, 2022
cc5760f
Code cleaned up
lgomezm Apr 18, 2022
6bb7779
Updated test_300_page.py file
lgomezm Apr 25, 2022
31fddeb
Added source tests
lgomezm Apr 26, 2022
6a599f0
Added stream tests
lgomezm Apr 26, 2022
44f786a
Addressed PR feedback
lgomezm May 4, 2022
7f5c7e0
Add explanatory comment
lgomezm May 4, 2022
8ac1a2f
Addressed more PR feedback
lgomezm May 5, 2022
a82b8a3
Leveraged response.raise_for_status
lgomezm May 5, 2022
12afc4a
Addressed PR feedback
lgomezm May 18, 2022
a0a3d94
format
alafanechere May 18, 2022
b7e15a7
Made requests_per_minute config param optional
lgomezm May 20, 2022
962ddf6
remove skills stream from tests
alafanechere May 23, 2022
a64b8cf
Fixed integration tests
lgomezm May 26, 2022
9cf2ba1
Fixed last rebase
lgomezm May 27, 2022
3eca841
readd skills + remove legacy changelog
alafanechere May 30, 2022
8634096
Merge branch 'master' into lgomez/freshdesk_migration
alafanechere May 30, 2022
e6094f4
auto-bump connector version
octavia-squidington-iii May 30, 2022
122c467
add endline
alafanechere May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@
- name: Freshdesk
sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
dockerRepository: airbyte/source-freshdesk
dockerImageTag: 0.2.11
dockerImageTag: 0.3.0
documentationUrl: https://docs.airbyte.io/integrations/sources/freshdesk
icon: freshdesk.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2405,7 +2405,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-freshdesk:0.2.11"
- dockerImage: "airbyte/source-freshdesk:0.3.0"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/freshdesk"
connectionSpecification:
Expand Down
21 changes: 0 additions & 21 deletions airbyte-integrations/connectors/source-freshdesk/CHANGELOG.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-freshdesk/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.11
LABEL io.airbyte.version=0.3.0
LABEL io.airbyte.name=airbyte/source-freshdesk
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@ tests:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ["satisfaction_ratings", "tickets", "time_entries", "conversations"]
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Loading