New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: LinkedIn Pages #13098

Merged

marcosmarxm merged 28 commits into airbytehq:master from jscottpolevault:master

Aug 11, 2022

Contributor

jscottpolevault commented May 23, 2022

What

Added a LinkedIn Company Pages connector

How

The Python CDK

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Tests

Unit

No Custom Unit Tests Added

Integration

PASSED

Acceptance

21 PASSED (ALL)

github-actions bot added area/connectors area/documentation labels

octavia-squidington-iii added the community label

jscottpolevault mentioned this pull request

🎉 New Source: LinkedIn Pages (old) #12894

Closed

12 tasks

jscottpolevault changed the title ~~🎉 New Source: LinkedIn Pages (2nd Attempt)~~ 🎉 New Source: LinkedIn Pages

Member

marcosmarxm commented May 27, 2022

@jscottpolevault can you post the output image of integration tests?

Contributor Author

jscottpolevault commented May 27, 2022

Is this what you're asking for @marcosmarxm?

marcosmarxm requested changes

View reviewed changes

Member

marcosmarxm left a comment

thanks for the contribution, sorry the long delay. Requested some changes.

.vscode/settings.json Outdated Show resolved Hide resolved

CODE_OF_CONDUCT 2.md Outdated Show resolved Hide resolved

CONTRIBUTING 2.md Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-linkedin-pages/integration_tests/abnormal_state.json Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json Outdated Show resolved Hide resolved

codecov 2.yml Outdated Show resolved Hide resolved

marcosmarxm self-assigned this

CLAassistant commented May 31, 2022 •

edited

Loading

All committers have signed the CLA.

Contributor Author

jscottpolevault commented May 31, 2022

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ jscottpolevault❌ Jordan Scott

Jordan Scott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@marcosmarxm - Sorry once again, but I had 2 github accounts and realized I didn't need both, so I deleted one of the accounts. I mistakenly "contributed" to this from both accounts, but now the CLA says it's not signed by all contributors... but it's just me.

Let me know if I can do anything on my end to fix this.

github-actions bot added area/api area/platform area/protocol area/scheduler area/server CDK normalization and removed area/documentation labels

jscottpolevault and others added 6 commits

June 1, 2022 14:38


          added linkedin pages source connector

2f402fc


          fixed last source acceptance test issue and passed all

3661d7d


          requested changes completed

df6dc8b


          fixed last source acceptance test issue and passed all

7636c45


          requested changes completed

c8c1d74


          added nulls to share_statistics schema

2dfe6b1

jscottpolevault force-pushed the master branch from d0a51af to 2dfe6b1 Compare

June 1, 2022 19:39

github-actions bot added area/documentation and removed area/scheduler area/api area/server labels

github-actions bot removed the normalization label

marcosmarxm removed request for a team

August 11, 2022 13:39

Member

marcosmarxm commented Aug 11, 2022 •

edited

Loading

Could you fix the diff?

@sherifnada my bad! It's fixed now.

marcosmarxm and others added 3 commits

August 11, 2022 10:19


          Merge branch 'master' into master

7343c3e


          remove gh file

e953f23


          make org_id secret

8043f57

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2840566412
❌ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2840566412
🐛


          change org_id to string

3e0ea7a

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2840704796
❌ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2840704796
🐛 https://gradle.com/s/w363ht6dkgeni

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
=================== 1 failed, 23 passed, 3 skipped in 21.98s ===================


          rollback org_id

6776bae

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841239434
❌ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841239434
🐛 https://gradle.com/s/rlaf63js6moww

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_config_match_spec[inputs0] - Failed: Conf...
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
============== 3 failed, 12 passed, 3 skipped, 9 errors in 23.59s ==============

marcosmarxm and others added 3 commits

August 11, 2022 13:44


          return org_id to integer

9cce626


          rollback to integrr after correct ci


          Merge branch 'master' into master

4917bd7

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841755866
❌ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841755866
🐛


          Merge branch 'master' into master

f22a28f

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841982239
✅ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/2841982239
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-214
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 24 passed, 3 skipped in 21.33s ========================


          correct docs

0f94d7c

Member

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

/publish connector=connectors/source-linkedin-pages

🕑 Publishing the following connectors:
connectors/source-linkedin-pages
https://github.com/airbytehq/airbyte/actions/runs/2842253590

Connector	Did it publish?	Were definitions generated?
connectors/source-linkedin-pages	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️


          auto-bump connector version [ci skip]

f0aa68b

Member

marcosmarxm commented Aug 11, 2022

Sorry the long delay to merge this @jscottpolevault I made some changes and removed 3 streams (posts and shares because they are legacy, and page_statistics) feel free to add them again in the future.

marcosmarxm approved these changes

View reviewed changes

marcosmarxm merged commit c6ed310 into airbytehq:master

octavia-squidington-iii mentioned this pull request

Bump Airbyte version from 0.40.0-alpha to 0.40.1-alpha #15775

Closed

evantahler mentioned this pull request

Bump Airbyte version from 0.40.0-alpha to 0.40.1 #15857

Merged

marcosmarxm mentioned this pull request

New Source: LinkedIn Pages #8348

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors area/documentation community connectors/source/linkedin-pages internal