Toggle off and on set -x when DOCKER_TOKEN is used

[noahkawasaki-airbyte]

What

This is why I'm not a fan of merging set -x into a repo :(

Toggling it on and off whenever the DOCKER_TOKEN is used.

How

Describe the solution

Recommended reading order

1. x.java
2. y.python

[noahkawasaki-airbyte]

Testing here https://github.com/airbytehq/airbyte/actions/runs/2398823593

[noahkawasaki-airbyte]

/publish connector=connectors/source-faker run-tests=false

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2398834087
🚀 Successfully published connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

[noahkawasaki-airbyte]

/publish connector=connectors/source-faker run-tests=false auto-bump-version=true

[evantahler]

We do use DOCKER_PASSWORD in a few other scripts, but not via curl (e.g. docker login --username airbytebot --password "${DOCKER_PASSWORD}"). I don't think this outputs anything sensitive

[noahkawasaki-airbyte]

Yeah, more importantly they are actual Github Secrets so GHA knows to mask them. The reason the tokens were an issue was because they are created during runtime..

[evantahler]

probably should modify the following files as well:

• https://github.com/airbytehq/airbyte/blob/master/tools/bin/gke-kube-acceptance-test/acceptance_test_kube_gke.sh#L47

[noahkawasaki-airbyte]

I dont see set -x in that file anywhere so that one should not be a problem. But I guess there is still a risk that someone adds in later

[evantahler]

Yeah, more importantly they are actual Github Secrets so GHA knows to mask them. The reason the tokens were an issue was because they are created during runtime..

Fascinating! if we set an empty secret would github have masked the output even if we change the value in the script later?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@fed651b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6680540 differs from pull request most recent head 3bff0cf. Consider uploading reports for the commit 3bff0cf to get more accurate results

@@            Coverage Diff            @@
##             master   #13293   +/-   ##
=========================================
  Coverage          ?   96.07%           
=========================================
  Files             ?        2           
  Lines             ?       51           
  Branches          ?        0           
=========================================
  Hits              ?       49           
  Misses            ?        2           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed651b...3bff0cf. Read the comment docs.

[noahkawasaki-airbyte]

That might be the solution actually, yeah.

[noahkawasaki-airbyte]

Confirmed this removes logging of tokens