🐛Destination-mssql: fixed integration tests #13304

etsybaev · 2022-05-28T16:12:05Z

What

Some of connectors had an issue with build process and integration tests.

How

Fixed tests, also bumped version to release new versions with updated core part.

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

etsybaev · 2022-05-28T16:12:52Z

/test connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2401560714
✅ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2401560714
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-05-28T17:37:31Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2401744370
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2401744370
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

…egration-tests

etsybaev · 2022-05-30T20:34:38Z

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2411216757
🚀 Successfully published connectors/destination-mssql
🚀 Auto-bumped version for connectors/destination-mssql
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2411216757

…egration-tests

etsybaev · 2022-05-31T07:31:53Z

/publish connector=connectors/destination-mssql-strict-encrypt auto-bump-version=false

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2413372024
❌ Failed to publish connectors/destination-mssql-strict-encrypt

etsybaev · 2022-05-31T07:41:13Z

mssql-strict-encrypt appears to be already released

* [13180] Destination-mssql: fixed integration tests

[13180] Destination-mssql: fixed integration tests

46fd8ee

github-actions bot added the area/connectors Connector related issues label May 28, 2022

etsybaev linked an issue May 28, 2022 that may be closed by this pull request

Fix broken integration tests and publish connectors #13180

Closed

8 tasks

alexandr-shegeda marked this pull request as ready for review May 30, 2022 12:05

alexandr-shegeda approved these changes May 30, 2022

View reviewed changes

etsybaev changed the title ~~Destination-mssql: fixed integration tests~~ 🐛Destination-mssql: fixed integration tests May 30, 2022

etsybaev added 3 commits May 30, 2022 21:00

Merge branch 'master' into etsybaev/13180-destination-mssql-fixed-int…

faf16b9

…egration-tests

Bumped destination mssql versions

d8411c6

Merge branch 'master' into etsybaev/13180-destination-mssql-fixed-int…

3d8587a

…egration-tests

auto-bump connector version

299ae5c

octavia-squidington-iii temporarily deployed to more-secrets May 30, 2022 21:53 Inactive

Merge branch 'master' into etsybaev/13180-destination-mssql-fixed-int…

7b28bd3

…egration-tests

etsybaev temporarily deployed to more-secrets May 31, 2022 06:56 Inactive

etsybaev merged commit 474349e into master May 31, 2022

etsybaev deleted the etsybaev/13180-destination-mssql-fixed-integration-tests branch May 31, 2022 07:42

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022

🐛Destination-mssql: fixed integration tests (airbytehq#13304)

d0c6d02

* [13180] Destination-mssql: fixed integration tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Destination-mssql: fixed integration tests #13304

🐛Destination-mssql: fixed integration tests #13304

etsybaev commented May 28, 2022 •

edited

Loading

etsybaev commented May 28, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 28, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 30, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 31, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 31, 2022

🐛Destination-mssql: fixed integration tests #13304

🐛Destination-mssql: fixed integration tests #13304

Conversation

etsybaev commented May 28, 2022 • edited Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

etsybaev commented May 28, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented May 28, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented May 30, 2022 • edited by github-actions bot Loading

etsybaev commented May 31, 2022 • edited by github-actions bot Loading

etsybaev commented May 31, 2022

etsybaev commented May 28, 2022 •

edited

Loading

etsybaev commented May 28, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 28, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 30, 2022 •

edited by github-actions bot

Loading

etsybaev commented May 31, 2022 •

edited by github-actions bot

Loading