Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the "properties" field to events.json #14585

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Added the "properties" field to events.json #14585

merged 3 commits into from
Jul 19, 2022

Conversation

juliatournant
Copy link
Contributor

What

In response to issue #14528 I raised a few days ago.

How

Added the field "properties" to events.json

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022

CLA assistant check
All committers have signed the CLA.

@natalyjazzviolin
Copy link
Contributor

natalyjazzviolin commented Jul 12, 2022

/test connector=connectors/source-posthog

🕑 connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/2657797627
❌ connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/2657797627
🐛 https://gradle.com/s/2beurcrae7mnk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
======================== 1 failed, 23 passed in 34.58s =========================

@natalyjazzviolin
Copy link
Contributor

Hey @juliatournant, thank you for the contribution! The integration tests are failing but should pass with one small fix:

In the cohorts.json schema please change the count type to ["integer", "null"] . Then we should be good to go!

Changed the count type to ["integer", "null"] (thanks to @natalyjazzviolin's advice!)
@juliatournant
Copy link
Contributor Author

Thank you @natalyjazzviolin, we should be good to go now :)

@natalyjazzviolin
Copy link
Contributor

natalyjazzviolin commented Jul 19, 2022

/test connector=connectors/source-posthog

🕑 connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/2698121514
✅ connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/2698121514
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_posthog/__init__.py       2      0   100%
source_posthog/source.py        28     10    64%
source_posthog/streams.py       96     52    46%
------------------------------------------------
TOTAL                          126     62    51%

Build Passed

Test summary info:

All Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants