Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization for Snowflake destination: added support for key pair authentication #14792

Merged
merged 8 commits into from
Jul 23, 2022
Merged

Normalization for Snowflake destination: added support for key pair authentication #14792

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7dce48c
Normalization for Snowflake destination: added support for key pair a…
sashaNeshcheret Jul 18, 2022
f02c29e
Normalization for Snowflake destination: updated changelogs
sashaNeshcheret Jul 18, 2022
5893178
Normalization for Snowflake destination: renamed property passphrase …
sashaNeshcheret Jul 18, 2022
aa85fa4
Merge remote-tracking branch 'origin/master' into 12255/normalization…
sashaNeshcheret Jul 21, 2022
49b888d
Normalization for Snowflake destination: bump normalization version i…
sashaNeshcheret Jul 21, 2022
17172e1
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret Jul 22, 2022
c8e300d
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret Jul 22, 2022
faafb1b
Normalization for Snowflake destination: added unit tests and change …
sashaNeshcheret Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/bases/base-normalization/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ WORKDIR /airbyte
ENV AIRBYTE_ENTRYPOINT "/airbyte/entrypoint.sh"
ENTRYPOINT ["/airbyte/entrypoint.sh"]

LABEL io.airbyte.version=0.2.8
LABEL io.airbyte.version=0.2.9
LABEL io.airbyte.name=airbyte/normalization
7 changes: 7 additions & 0 deletions airbyte-integrations/bases/base-normalization/normalization/transform_config/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ def transform_snowflake(config: Dict[str, Any]):
dbt_config["oauth_client_id"] = credentials["client_id"]
dbt_config["oauth_client_secret"] = credentials["client_secret"]
dbt_config["token"] = credentials["refresh_token"]
elif credentials.get("private_key"):
f = open("private_key_path.txt", "w")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: prefer with open()... as f over open()... close(); this is basically equivalent to Java's try (OutputStream s = ...):

with open("private_key_path.txt", "w") as f:
  f.write(credentials["private_key"])

(then you don't need to f.close() at all)

f.write(credentials["private_key"])
f.close()
dbt_config["private_key_path"] = "private_key_path.txt"
if credentials.get("passphrase"):
dbt_config["private_key_passphrase"] = credentials["passphrase"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the authentication options that will be added to the Snowflake Destination will be called "private_key" and "passphrase". Does this match other destinations?

Copy link
Contributor Author

@sashaNeshcheret sashaNeshcheret Jul 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"private_key" - is widely used in other connectors, "passphrase" - is just snowflake terminology, renamed it to password @evantahler

elif credentials.get("password"):
dbt_config["password"] = credentials["password"]
else:
Expand Down
2 changes: 1 addition & 1 deletion ...te-workers/src/main/java/io/airbyte/workers/normalization/NormalizationRunnerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
public class NormalizationRunnerFactory {

public static final String BASE_NORMALIZATION_IMAGE_NAME = "airbyte/normalization";
public static final String NORMALIZATION_VERSION = "0.2.8";
public static final String NORMALIZATION_VERSION = "0.2.9";

static final Map<String, ImmutablePair<String, DefaultNormalizationRunner.DestinationType>> NORMALIZATION_MAPPING =
ImmutableMap.<String, ImmutablePair<String, DefaultNormalizationRunner.DestinationType>>builder()
Expand Down
1 change: 1 addition & 0 deletions docs/understanding-airbyte/basic-normalization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ Therefore, in order to "upgrade" to the desired normalization version, you need

| Airbyte Version | Normalization Version | Date | Pull Request | Subject |
|:----------------| :--- | :--- | :--- | :--- |
| | 0.2.9 | 2022-07-18 | [\#14792](https://github.com/airbytehq/airbyte/pull/14792) | Add support for key pair auth for snowflake |
| | 0.2.8 | 2022-07-13 | [\#14522](https://github.com/airbytehq/airbyte/pull/14522) | BigQuery replaces `NULL` array entries with the string value `"NULL"` |
| | 0.2.7 | 2022-07-05 | [\#11694](https://github.com/airbytehq/airbyte/pull/11694) | Do not return NULL for MySQL column values > 512 chars |
| | 0.2.6 | 2022-06-16 | [\#13894](https://github.com/airbytehq/airbyte/pull/13894) | Fix incorrect jinja2 macro `json_extract_array` call |
Expand Down