Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace twttr repo to the root build.gradle #15544

Merged
merged 13 commits into from
Aug 11, 2022
Merged

Replace twttr repo to the root build.gradle #15544

merged 13 commits into from
Aug 11, 2022

Conversation

VitaliiMaltsev
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 11, 2022
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets August 11, 2022 11:16 Inactive
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets August 11, 2022 11:19 Inactive
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets August 11, 2022 12:21 Inactive
@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review August 11, 2022 13:03
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets August 11, 2022 13:06 Inactive
@VitaliiMaltsev VitaliiMaltsev merged commit 43b3cd8 into master Aug 11, 2022
@VitaliiMaltsev VitaliiMaltsev deleted the vmaltsev/replace-twttr-repo-to-the-root-build-gradle branch August 11, 2022 13:09
@VitaliiMaltsev VitaliiMaltsev mentioned this pull request Aug 11, 2022
Merged
37 tasks
girarda pushed a commit that referenced this pull request Aug 11, 2022
@VitaliiMaltsev @alexandr-shegeda @girarda
Replace twttr repo to the root build.gradle (#15544)
6155072 
* Fixed bucket naming for S3

* replaced twttr repo to the root build.gradle

* replaced twttr repo to the root build.gradle

Co-authored-by: Oleksandr Sheheda <[email protected]>
girarda added a commit that referenced this pull request Aug 12, 2022
@girarda @midavadim
@octavia-squidington-iii @xiaohansong @tuliren @teallarson @marcosmarxm @RickRen7575 @davinchia @brianjlai @alafanechere @grubberr @juliatournant @davydov-d @xpuska513 @VitaliiMaltsev @alexandr-shegeda @jdpgrailsdev @mohamagdy
migrate greenhouse to config-based cdk (#15344)
04f34d7 
* greenhouse minus pagination

* jobs

* first substream

* rename field

* applications_demographics_answers_stream

* interviews

* All streams are implemented

* fix check

* fix spec

* disable backward compatibility tests

* disable backward compatibility tests

* unit tests

* definitions

* only use config.json

* bump version

* expected records

* delete stream classes

* Handle extracting no records from root

* handle missing keys

* Remove unused field from JsonSchema (#15425)

* few fixes from working with sendgrid

* reset to master

* only update the docstring

* reset

* 🎉 Source File - add support for custom encoding (#15293)

* added support for custom encoding

* fixed unit test for utf16

* updated docs

* bumped connector version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>

* change query frequency to 1hour (#15499)

* [low-code connectors]: Assert there are no custom top-level fields (#15489)

* move components to definitions field

* Also update the references

* validate the top level fields and add version

* raise exception on unknown fields

* newline

* unit tests

* set version to 0.1.0

* newline

* 🐞 Postgres source: fix bug in intermediate state emission (#15496)

* Rename record counter

* Rename method

* Emit intermediate state after all cursor records

* Emit intermediate state only when it is ready

* Merge two checks

* Add a testing message

* Fix unit tests

* Add one more testing record and add comments

* Add test case for multiple records with the same cursor value

* Revert irrelevant change

* Add explanation in javadoc

* Format code

* Rename testing methods

* Fix comment

* Bump version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>

* 🪟 🔧 Add testing and storybook component for CatalogDiffModal (#15426)

* wip diff modal test setup

* starting storybook add

* storybook working now

* cleanup

* aria labels

* test syncmode string

* 🎉 New Source: Hubplanner (#15521)

* added hubplanner source connector

* feat: added more streams to read from

* cleaned up some unneeded integration tests

* fix hubplanner schema

* changes

* update dockerfile

* add seed and doc

* update spec

* run source spec seed file

Co-authored-by: Ricky Renner <[email protected]>

* Make it possible to specify normalization pod resources. (#15495)

Today we are running into OOM exceptions with normalization. Normalization itself also inherits the destination's resource requirements. After work to bring destination memory usage down, this is no longer ideal, since most destinations use less memory than normalization needs.

This PR makes it possible to specify the general resource the normalization pod is provided via env vars.

Notes:
- Add env vars. Default to the various job main container resources if these are not set.
- Instead of using the destination's memory, use the normalization specify env vars.

* [low-code connectors] Extract datetime parser and handle %s format directive (#15429)

* fix parse

* Revert "fix parse"

This reverts commit 3c76c5a.

* fix parse timestamp

* extract datetime parser

* remove print

* use parser

* top level docstring

* rename variable

* do not use timestamp()

* Revert "do not use timestamp()"

This reverts commit 016cb69.

* update comment

* bump cdk version

* Update template

* source-file-secure bump to 0.2.16 (#15528)

* update Dockerfile version

* update init to accept additional args

* unit test sendgrid messages stream (#15331)

* unit test sendgrid messages stream

* reset

* Update airbyte-integrations/connectors/source-sendgrid/unit_tests/unit_test.py

Co-authored-by: Augustin <[email protected]>

Co-authored-by: Augustin <[email protected]>

* record extractor interface

* dpath extractor

* docstring

* 🎉 Source File: cache binary stream to file (#15501)

Signed-off-by: Sergey Chvalyuk <[email protected]>

* Docs: update posthog.md (#15541)

* Source Stripe: implement slicing (#15292)

* #45 oncall - source Stripe: implement slicing

* #45 source stripe: upd changelog

* #45 source stripe: upd changelog

* #45 source stripe: make slice range configurable

* #45 source stripe: move generating a single slice into a mixin

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>

* fix: revert extraEnv delition in values.yaml for bootloader (#15548)

* fix: revert extraEnv delition in values.yaml for bootloader

* add newline

* SAT: backward compatibility - check that cursor fields were not changed (#15520)

* Replace twttr repo to the root build.gradle (#15544)

* Fixed bucket naming for S3

* replaced twttr repo to the root build.gradle

* replaced twttr repo to the root build.gradle

Co-authored-by: Oleksandr Sheheda <[email protected]>

* Generate separate server endpoints per domain (#15513)

* 🐛 Backward compatibility test: Don't fail on updating additionalProperties (#15532)

* Source Recurly: adds `state_checkpoint_interval` to streams (#13685)

* Add `state_checkpoint_interval` to Recurly stream

* Bumpg Recurly source version to `0.4.1`

* reset

* use dpath

* enable backward compatibility test

* infer types

* Revert "infer types"

This reverts commit b4de8d6.

* infer some of the types

* some drying

* more drying

* auto-bump connector version [ci skip]

Signed-off-by: Sergey Chvalyuk <[email protected]>
Co-authored-by: midavadim <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Co-authored-by: Xiaohan Song <[email protected]>
Co-authored-by: Liren Tu <[email protected]>
Co-authored-by: Teal Larson <[email protected]>
Co-authored-by: Marcos Marx <[email protected]>
Co-authored-by: Ricky Renner <[email protected]>
Co-authored-by: Davin Chia <[email protected]>
Co-authored-by: Brian Lai <[email protected]>
Co-authored-by: Augustin <[email protected]>
Co-authored-by: Serhii Chvaliuk <[email protected]>
Co-authored-by: juliatournant <[email protected]>
Co-authored-by: Denys Davydov <[email protected]>
Co-authored-by: Kyryl Skobylko <[email protected]>
Co-authored-by: VitaliiMaltsev <[email protected]>
Co-authored-by: Oleksandr Sheheda <[email protected]>
Co-authored-by: Jonathan Pearlin <[email protected]>
Co-authored-by: Mohamed Magdy <[email protected]>
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Aug 19, 2022
Closed
@evantahler evantahler mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliiMaltsev @alexandr-shegeda @octavia-squidington-iii