Track Max & mean seconds to receive state messages #15586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
alovew
requested review from
evantahler,
gosusnp,
benmoriceau and
jdpgrailsdev
evantahler
approved these changes
Aug 12, 2022
Comment on lines
24
to
27
| meanSecondsBeforeStateMessageEmitted: | ||
| type: integer | ||
| maxSecondsBeforeStateMessageEmitted: | ||
| type: integer |
There was a problem hiding this comment.
A comment is probably valuable for future us - that this message is from the Source.
Comment on lines
+124
to
+126
| if (firstRecordReceivedAt == null) { | ||
| firstRecordReceivedAt = DateTime.now(); | ||
| } |
There was a problem hiding this comment.
👍 this is a global time, and not per-stream
Comment on lines
557
to
558
| when(messageTracker.getMaxSecondsToReceiveStateMessage()).thenReturn(10L); | ||
| when(messageTracker.getMeanSecondsToReceiveStateMessage()).thenReturn(8L); |
Comment on lines
83
to
84
| this.maxSecondsToReceiveStateMessage = new AtomicLong(0L); | ||
| this.meanSecondsToReceiveStateMessage = new AtomicLong(0L); |
There was a problem hiding this comment.
👍 These values will always be numeric (never null)
alovew
force-pushed
the
anne/max-and-mean-time-to-receive-state-message
branch
from
3635a31 to
8f19838
Compare
gosusnp
reviewed
Aug 12, 2022
| maxSecondsToReceiveSourceStateMessage.set(secondsSinceLastStateMessage); | ||
| } | ||
|
|
||
| if (meanSecondsToReceiveSourceStateMessage.get() == 0) { |
There was a problem hiding this comment.
I am wondering why are we using AtomicLong? Overall, it feels like we should be either using a Long or trying to leverage the atomic updates such as compareAndExchange.
There was a problem hiding this comment.
I was mostly just following the convention in the messagetracker for how we're tracking the other data
gosusnp
approved these changes
Aug 12, 2022
rodireich
pushed a commit
that referenced
this pull request
Aug 20, 2022
* Segment tracking for max and mean seconds to receive state message from source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track max and mean seconds before receiving state message in Segment.