Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alert banner #15596

Merged

Conversation

matter-q
Copy link
Contributor

What

Closes #15594

How

Fixed alert banner

Screenshot

image

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 12, 2022
@matter-q matter-q marked this pull request as ready for review August 12, 2022 11:39
@matter-q matter-q requested a review from a team as a code owner August 12, 2022 11:39
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you know what caused this regression?

@matter-q
Copy link
Contributor Author

Would you know what caused this regression?

My previous PR. I had cached properties and forgot it add them to the codebase

@matter-q matter-q merged commit 6d9ae93 into master Aug 12, 2022
@matter-q matter-q deleted the mark/alert-banner-should-be-placed-on-the-top-of-the-screen branch August 12, 2022 14:24
bluesky-bot pushed a commit to getbluesky/airbyte that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An Alert banner should be placed on the top of the screen
2 participants