-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Iterable - API key is passed in headers #15670
🎉 Source Iterable - API key is passed in headers #15670
Conversation
/test connector=connectors/source-iterable
Build FailedTest summary info:
|
/test connector=connectors/source-iterable
|
/test connector=connectors/source-iterable
Build FailedTest summary info:
|
/test connector=connectors/source-iterable
Build FailedTest summary info:
|
/test connector=connectors/source-iterable
Build FailedTest summary info:
|
/test connector=connectors/source-iterable
Build FailedTest summary info:
|
/test connector=connectors/source-iterable
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes lgtm. Could you edit the main comment of the PR to explain the what and why of this change please (for clarity) :)
…rce-iterable-use-apikey-in-header # Conflicts: # docs/integrations/sources/iterable.md
/publish connector=connectors/source-iterable
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* API key is passed in headers * updated docs * removed log * formatted * fixed tests * increased timeout for incremental stream * bumper source version * bumper source version in seed * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>
What
Connector sync fails with 401 as response code status due to not set the api-key through request headers.
For more info Iterable API-keys docs
How
api key is passed via header instead of query param
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.