Add scheduled service #15761
Merged
Add scheduled service #15761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
benmoriceau
force-pushed
the
bmoric/self-healing-service
branch
from
21da7b0 to
c64325e
Compare
benmoriceau
commented
Aug 18, 2022
| container_name: airbyte-cron | ||
| restart: unless-stopped | ||
| environment: | ||
| - DB=postgresql |
There was a problem hiding this comment.
This is not need now but it will be needed in the future for sure. It is better to put it now.
benmoriceau
force-pushed
the
bmoric/self-healing-service
branch
from
c64325e to
22bc9a7
Compare
| public class MicronautCronRunner { | ||
|
|
||
| @Inject | ||
| Temporal temporal; |
There was a problem hiding this comment.
If this is just to ensure that the bean gets created, you could also do this through an ApplicationListener or by configuring Micronaut to do eager initialization of Singletons.
|
I'm probably missing the helm chart in this PR. |
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
* Add logger scheduled service * Use eager bean initialization
|
Hi just want to ask @benmoriceau why there is cron deployment. but in the helm charts there isnt This caused this issue #16698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is adding a new app in docker and kube. This app is a micronaut server which allow to have Bean being inject into it. The goal of those bean is to run scheduled activities. The example service is not doing anything on purpose and should be consider as a template.
It has been manually tested on docker using a log.