Fix build by marking id columns as primary keys in test files #15774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmossman
force-pushed
the
parker/fix-incremental-acceptance-tests
branch
from
10de6c6 to
28e46b6
Compare
edgao
reviewed
Aug 19, 2022
| @@ -1,7 +1,7 @@ | |||
| CREATE | |||
| TABLE | |||
| id_and_name( | |||
| id INTEGER, | |||
| id INTEGER PRIMARY KEY, | |||
There was a problem hiding this comment.
can this be INTEGER NOT NULL? (this is a mild preference just to minimize the change)
There was a problem hiding this comment.
Good call, that should work without requiring any changes to the test logic
pmossman
force-pushed
the
parker/fix-incremental-acceptance-tests
branch
from
53a5c0c to
d79d785
Compare
ryankfu
reviewed
Aug 19, 2022
ryankfu
approved these changes
Aug 19, 2022
|
Thanks for the review Ed and Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14356 we changed how supported sync modes are determined: a source stream must have at least one field that can be used as a cursor in order for the stream to support incremental syncing.
The Postgres sources that we use in acceptance test weren't declaring
idcolumns as primary keys, which meant they were nullable and thus could not be used as cursor columns.This broke some of our acceptance tests that tested the behavior of incremental syncs. This PR modifies the seed sql we use in these tests to declare the
idcolumn as a primary key, so that incremental can be supported.