source instagram: ask for pages_show_list,pages_read_engagement scopes during oauth #15802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s during oauth flow
pedroslopez
approved these changes
Aug 19, 2022
|
Do we have a way of knowing if this worked? |
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
…s during oauth flow (#15802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Context in https://github.com/airbytehq/oncall/issues/322
How
This is a shot in the dark because reproducing this error is hard. It requires having an instagram business account, linked to a facebook page, accessible by a user who is not a member of Airbyte's business account. Setting this up will take time because Facebook requires real people to sign up for these accounts and requires actual business verification etc.. I'm also not sure how to mock this or if it's possible to do via some facebook provided sandbox. So here goes nothing.
Something which stood out to me is that facebook mentions we need the
pages_show_listpermission to get a customer's accounts, which we clearly do in this step. We even say in our docs for OSS users that this is required. So it certainly seems like a valid shot in the dark. I also added thepages_read_engagementpermission for good measure since it allows an app toread metadata and other insights about the Pagewhich seems vague enough that it is probably relevant. Again I would prefer to have exact reproducible scenarios here but we're sort of pressed for time on the linked issue.