convert the workspace update api to patch style #16739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
pmossman
approved these changes
Sep 22, 2022
| if (workspacePatch.getSecurityUpdates() != null) { | ||
| workspace.setSecurityUpdates(workspacePatch.getSecurityUpdates()); | ||
| } | ||
| if (workspacePatch.getEmail() != null) { |
There was a problem hiding this comment.
It looks like the old code was doing a nullOrEmpty check, but the new code is just checking for null. Maybe the best thing to do for the new code would be to add a validation in validateWorkspacePatch that the email address is properly formed? Or at least not an empty string?
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* convert the workspace api to patch style * check for empty email in workspace update
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* convert the workspace api to patch style * check for empty email in workspace update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Convert the workspace update API to accept PATCH-style updates.
How
Only apply updates from request parameters that have been specified.
Recommended reading order
airbyte-server/src/main/java/io/airbyte/server/handlers/WorkspacesHandler.javaairbyte-server/src/test/java/io/airbyte/server/handlers/WorkspacesHandlerTest.java