Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source BambooHR: Add custom fields validation #16826

Merged
merged 10 commits into from
Sep 27, 2022

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Sep 16, 2022

What

#15170 - BambooHR Custom Fields Delivered As NULL
User hasn't access to custom fields

Deleted employees directory stream. Reason - not supported by service:
image

How

Add custom fields validation during check.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 16, 2022
@lazebnyi lazebnyi changed the title Source BambooHR: Add custom fields validation 🎉 Source BambooHR: Add custom fields validation Sep 16, 2022
@lazebnyi lazebnyi linked an issue Sep 16, 2022 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 16, 2022

/test connector=connectors/source-bamboo-hr

🕑 connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3070363136
❌ connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3070363136
🐛

@lazebnyi lazebnyi requested a review from bazarnov September 20, 2022 07:59
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 20, 2022

/test connector=connectors/source-bamboo-hr

🕑 connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3088436472
❌ connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3088436472
🐛 https://gradle.com/s/ztn7v5ueshtqo

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 3 failed, 23 passed, 1 skipped in 21.48s ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 27, 2022

/test connector=connectors/source-bamboo-hr

🕑 connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3135325383
❌ connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3135325383
🐛 https://gradle.com/s/kijm5mql2xere

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 2 failed, 24 passed, 1 skipped in 20.83s ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 27, 2022

/test connector=connectors/source-bamboo-hr

🕑 connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3135446853
✅ connectors/source-bamboo-hr https://github.com/airbytehq/airbyte/actions/runs/3135446853
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_bamboo_hr/utils.py           9      0   100%
source_bamboo_hr/exception.py      12      0   100%
source_bamboo_hr/__init__.py        2      0   100%
source_bamboo_hr/source.py         96     16    83%
---------------------------------------------------
TOTAL                             119     16    87%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.2.0.
======================== 25 passed, 2 skipped in 19.68s ========================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 27, 2022

/publish connector=connectors/source-bamboo-hr

🕑 Publishing the following connectors:
connectors/source-bamboo-hr
https://github.com/airbytehq/airbyte/actions/runs/3135773880


Connector Did it publish? Were definitions generated?
connectors/source-bamboo-hr

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi merged commit f10550a into master Sep 27, 2022
@lazebnyi lazebnyi deleted the lazebnyi/source-bamboohr-custom-fields-validation branch September 27, 2022 13:19
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Add custom fields validation

* Updated PR number

* Deleted employees_directory_stream

* Fix tests

* auto-bump connector version [ci skip]

* Updated docs

* Updated changelog

Co-authored-by: Octavia Squidington III <[email protected]>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Add custom fields validation

* Updated PR number

* Deleted employees_directory_stream

* Fix tests

* auto-bump connector version [ci skip]

* Updated docs

* Updated changelog

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bamboo-hr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BambooHR Custom Fields Delivered As NULL
3 participants