Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused webbackend search code. #17008

Merged
merged 11 commits into from
Sep 26, 2022

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Sep 21, 2022

What

Similar to #17006. We want to removed all the unused web backend routes to clean things up.

How

  • Delete all relevant code.

Recommended reading order

All files.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@davinchia davinchia requested a review from timroes September 21, 2022 21:01
@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server labels Sep 21, 2022
@davinchia davinchia requested review from git-phu and terencecho and removed request for git-phu September 21, 2022 21:01
@davinchia davinchia temporarily deployed to more-secrets September 21, 2022 21:02 Inactive
@davinchia davinchia marked this pull request as ready for review September 21, 2022 21:04
Copy link
Contributor

@terencecho terencecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also have to remove WebBackendConnectionSearch from this file? and all the generated code?

@davinchia davinchia temporarily deployed to more-secrets September 21, 2022 21:10 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 21, 2022 21:17 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 21, 2022 21:29 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 22, 2022 00:04 Inactive
…f github.com:airbytehq/airbyte into davinchia/remove-unused-webbackend-connection-search
@davinchia davinchia temporarily deployed to more-secrets September 22, 2022 01:06 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 22, 2022 16:29 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 23, 2022 17:18 Inactive
@davinchia davinchia temporarily deployed to more-secrets September 23, 2022 18:33 Inactive
@pmossman pmossman temporarily deployed to more-secrets September 26, 2022 15:38 Inactive
@pmossman
Copy link
Contributor

@davinchia since you're out sick and I have a dependency on this PR in the removal of catalogs from the list_connections endpoint, I'm going to take over getting this PR to the finish line today. Rest up and get better soon!

Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build the app locally. If this broke something it would be noticed during build. LGTM!

@pmossman pmossman merged commit 517466e into master Sep 26, 2022
@pmossman pmossman deleted the davinchia/remove-unused-webbackend-connection-search branch September 26, 2022 17:46
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Remove unused webbackend search code.

* Remove unused request body.

* Remove unused request body.

* Remove failing test.

* Remove failing test.

* Remove failing test.

Co-authored-by: Parker Mossman <[email protected]>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Remove unused webbackend search code.

* Remove unused request body.

* Remove unused request body.

* Remove failing test.

* Remove failing test.

* Remove failing test.

Co-authored-by: Parker Mossman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants