-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused webbackend search code. #17008
Remove unused webbackend search code. #17008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also have to remove WebBackendConnectionSearch
from this file? and all the generated code?
…f github.com:airbytehq/airbyte into davinchia/remove-unused-webbackend-connection-search
@davinchia since you're out sick and I have a dependency on this PR in the removal of catalogs from the list_connections endpoint, I'm going to take over getting this PR to the finish line today. Rest up and get better soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build the app locally. If this broke something it would be noticed during build. LGTM!
* Remove unused webbackend search code. * Remove unused request body. * Remove unused request body. * Remove failing test. * Remove failing test. * Remove failing test. Co-authored-by: Parker Mossman <[email protected]>
* Remove unused webbackend search code. * Remove unused request body. * Remove unused request body. * Remove failing test. * Remove failing test. * Remove failing test. Co-authored-by: Parker Mossman <[email protected]>
What
Similar to #17006. We want to removed all the unused web backend routes to clean things up.
How
Recommended reading order
All files.
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.