🪟 🐛 Fix error message with missing docs #17071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
krishnaglick
approved these changes
Sep 23, 2022
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Fix error message with missing docs (airbytehq#17014) * Reverse type check logic
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Fix error message with missing docs (airbytehq#17014) * Reverse type check logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This reimplements the reverted #17014 but with a flipped logic for the content-type.
Fixes an error where if a markdown doesn't exist for an internal documentation will actually show part of our HTML instead:
How
This happened because if the markdown doesn't exist we actually (thanks to being a SPA) deliver our HTML instead. We had a check so far that checked if the response contained
<!DOCTYPE html>and if so treat it as an error and show no documentation found. The problem was, that after minification this became<!doctype html>(lower case), and such the check didn't work anymore.I've changed this logic a bit to actually check if the
content-typeafter loading the documentation is actually nottext/html(which is the case if the markdown isn't found and instead it delivers ourindex.html), and if not throw actually and show the "Documentation not found" error instead. You can currently test this with the "Google Firestore" destination, which does not have a valid Markdown documentation.