🪟 🧹 Move minor UI components to compoents/ui #17109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
approved these changes
Sep 23, 2022
edmundito
force-pushed
the
edmundito/organize-components
branch
from
03db275 to
d05db51
Compare
edmundito
force-pushed
the
edmundito/organize-components
branch
from
d05db51 to
e24f89d
Compare
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* SingletonCard to ui/components/Toast * Move Spinner to components/ui * Move SlickSlider to components/ui * Move ProgressBar to components/ui and add storybook * Move Markdown to components/ui * Move CatalogDiffModal story to its own group * Move CodeEditor to components/ui, add storybook * Move TextWithHTML to components/ui * Move StepsMenu to components/ui, add Storybook * Add args to CodeEditor and TextWithHTML storybooks * Move SideMenu to components/ui * Fix progressbar storybook args * Add ReleaseStateBadge story * Move ImageBlock to components/ui * Move BarChart to components/ui and add storybook * Move Breadrumbs to components/ui * Move LoadingBackdrop to components/ui * Move InfoBox to components/ui and add storybook * Fix unit tests
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* SingletonCard to ui/components/Toast * Move Spinner to components/ui * Move SlickSlider to components/ui * Move ProgressBar to components/ui and add storybook * Move Markdown to components/ui * Move CatalogDiffModal story to its own group * Move CodeEditor to components/ui, add storybook * Move TextWithHTML to components/ui * Move StepsMenu to components/ui, add Storybook * Add args to CodeEditor and TextWithHTML storybooks * Move SideMenu to components/ui * Fix progressbar storybook args * Add ReleaseStateBadge story * Move ImageBlock to components/ui * Move BarChart to components/ui and add storybook * Move Breadrumbs to components/ui * Move LoadingBackdrop to components/ui * Move InfoBox to components/ui and add storybook * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to #17101
Moves all less frequently used UI components to the
components/uifolder, cleans ups the way they are imported to a single standard way, and adds storybooks.This change is only a part of moving all relevant components to the
uisubfolder. Components that are more frequently used and components inbase/will be moved separatelyHow
components/uiRecommended reading order
Top to bottom