Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Snowflake: Handle date-time data types #17144

Merged
merged 7 commits into from
Sep 27, 2022
Merged

Source Snowflake: Handle date-time data types #17144

merged 7 commits into from
Sep 27, 2022

Conversation

VitaliiMaltsev
Copy link
Contributor

@VitaliiMaltsev VitaliiMaltsev commented Sep 26, 2022 •
edited
Loading

What

Fix for https://github.com/airbytehq/alpha-beta-issues/issues/319

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 26, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 26, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Sep 26, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3128843822
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3128843822
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

@VitaliiMaltsev VitaliiMaltsev marked this pull request as ready for review September 26, 2022 18:20
@VitaliiMaltsev VitaliiMaltsev requested a review from a team as a code owner September 26, 2022 18:20
edgao
edgao reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to bump the dockerfile version :)

...wflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSourceOperations.java Show resolved Hide resolved
...wflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSourceOperations.java Show resolved Hide resolved
...wflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSourceOperations.java Show resolved Hide resolved
...wflake/src/main/java/io.airbyte.integrations.source.snowflake/SnowflakeSourceOperations.java Show resolved Hide resolved
@VitaliiMaltsev
Merge branch 'master' into vmaltsev/319-source-snowflake-handle-date-…
905f4c4 
…time

# Conflicts:
#	docs/integrations/sources/snowflake.md
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

edgao
edgao approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Sep 27, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-snowflake

🕑 Publishing the following connectors:
connectors/source-snowflake
https://github.com/airbytehq/airbyte/actions/runs/3137085107


Connector Did it publish? Were definitions generated?
connectors/source-snowflake ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-snowflake

@VitaliiMaltsev VitaliiMaltsev merged commit b8dfed0 into master Sep 27, 2022
@VitaliiMaltsev VitaliiMaltsev deleted the vmaltsev/319-source-snowflake-handle-date-time branch September 27, 2022 16:12
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 27, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 28, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@VitaliiMaltsev @octavia-squidington-iii @robbinhan
Source Snowflake: Handle date-time data types (airbytehq#17144)
f10a304 
* Source Snowflake: Handle date-time data types

* updated changelog

* replaced star import

* bump version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@VitaliiMaltsev @octavia-squidington-iii @jhammarstedt
Source Snowflake: Handle date-time data types (airbytehq#17144)
23ad799 
* Source Snowflake: Handle date-time data types

* updated changelog

* replaced star import

* bump version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@grishick grishick grishick approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliiMaltsev @grishick @edgao @octavia-squidington-iii